Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(dev): フロントエンド・バックエンドを分離する開発モードを廃止 #15284

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 15, 2025

This reverts commit b0039f0.

What

書いてあるとおり
(とりあえず動きはしたけど何かおかしくなっているかもしれないのでよく確認してからマージすること)

Why

#15255 によりHMRが効かない問題が解消されたため

Fix #15186
Fix #12641

(その他、開発モード導入に従って提出されたissueがすべて解決される)

Additional info (optional)

  • 分離した開発モードを使用している間にアップロードしたドライブファイルなどが読み込めなくなる可能性がある
  • アクセスするポート番号が変わるためconfigファイルを変更する必要がある場合がある

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.00%. Comparing base (002e939) to head (783be44).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/welcome.entrance.a.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15284       +/-   ##
============================================
- Coverage    39.43%   20.00%   -19.44%     
============================================
  Files         1568      730      -838     
  Lines       199142   104404    -94738     
  Branches      3656     1199     -2457     
============================================
- Hits         78537    20886    -57651     
+ Misses      120032    82965    -37067     
+ Partials       573      553       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
1 participant