ansible_mitogen: Respect interpreter_python and ANSIBLE_PYTHON_INTERPRETER #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreati
force-pushed
the
issue1083-python_path2
branch
7 times, most recently
from
80f7f75 to
bce129f
Compare
moreati
changed the title
Closed
…RETER This adapts PR mitogen-hq#740 by @extmind (afe0026), which augmented the call to `Connection.get_task_var()` with `C.config.get_config_value('INTERPRETER_PYTHON'` as a default. Instead this *replaces* the call to `Connection.get_task_var()`. The aim is greater simplicity by disentangling templating of a configured interpreter path and discovery of an interpreter when none is configured. I think this also reduces the number of times `Connection._get_task_vars()` is called, so reducing the number of times we do the ugly stack frame inspection. I've also added test cases. Co-authored-by: Lars Beckers <lars@extmind.de>
moreati
force-pushed
the
issue1083-python_path2
branch
from
bce129f to
945e360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts PR #740 by @extmind (afe0026), which augmented the call to
Connection.get_task_var()withC.config.get_config_value('INTERPRETER_PYTHON')as a default. Instead this replaces the call toConnection.get_task_var(). The aim is greater simplicity by disentangling templating of a configured interpreter path and discovery of an interpreter when none is configured. I think this also reduces the number of timesConnection._get_task_vars()is called, so reducing the number of times we do the ugly stack frame inspection.I've also added test cases.
fixes #740, refs #833