Fix synchronization bug for GPU stream async CPU work #1768
+39
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes synchronization bugs for asynchronous CPU work that happens in the GPU stream.
The basic premise is that the output events were getting signaled before all the work in the GPU stream actually completed.
For example:
The
load
would signal the event value to2
without ensuring thata
was actually finished causing theall_sum
to start prematurely.The fix is to simply make a new event for primitives like
Load
and the distributed ops that need to synchronize with the GPU.