-
Notifications
You must be signed in to change notification settings - Fork 39
Weak reference support #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI this is the change that fixed the weak processor wenyuzhao@1bd175f. This is also a part of #141. This change removes the code that treats all the WeakProcessor objects as roots. I'm afraid without this fix, a lot of weak objects will be kept alive. We should include the change in this PR to deal with weak pointers correctly. Probably this will also yield better performance. |
@wenyuzhao It seems, to apply the changes in the commit, I need to remove the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds weak reference support, and updates MMTk core to mmtk/mmtk-core#564.