Skip to content

Please add iSuite25 to tool list #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 26, 2025
Merged

Conversation

geniusbigfive
Copy link
Contributor

@geniusbigfive geniusbigfive commented May 5, 2025

Hello All
This is daeoh from IVH

My company make a iSuite25 for FMI simulation tool.
So, I hope to add a tool list.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your tool!
The "features" are foreseen for a future list of FMI features supports. This is not yet defined, so please remove them currently.

(It would be great if you could provide provide compatibility information (see https://github.com/modelica/fmi-standard.org/blob/main/CONTRIBUTING.md#compatibility-information), i.e. how you tested your FMI implementation?
Could also be in a separate Pull Request.
Benefit for you: your tool will get the "yellow star" and be listed on the top.)

@geniusbigfive
Copy link
Contributor Author

Thanks for adding your tool! The "features" are foreseen for a future list of FMI features supports. This is not yet defined, so please remove them currently.

(It would be great if you could provide provide compatibility information (see https://github.com/modelica/fmi-standard.org/blob/main/CONTRIBUTING.md#compatibility-information), i.e. how you tested your FMI implementation? Could also be in a separate Pull Request. Benefit for you: your tool will get the "yellow star" and be listed on the top.)

Hello Chrbertsch

I modified the tool.json file. Please check it out.

I will seperate pull request to provide compatibility information.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geniusbigfive: I moved the content of the .json file to the overall tools.json file and removed some blank lines. Please check.

I get security warnings when I want to open your vendorURL https://www.ivh.co.kr/.

Can You provide and URL for your tool?

@chrbertsch
Copy link
Collaborator

@geniusbigfive : I do not get the warning when I change "https://www.ivh.co.kr/" to "www.ivh.co.kr". Shall we fix this accordingly, or do you plan updates with the "https" version of your website?
Can you please also provide an URL for you tool?

@geniusbigfive
Copy link
Contributor Author

@geniusbigfive : I do not get the warning when I change "https://www.ivh.co.kr/" to "www.ivh.co.kr". Shall we fix this accordingly, or do you plan updates with the "https" version of your website? Can you please also provide an URL for you tool?

We will update "http" to "https", We also prove URL about our tools.

geniusbigfive and others added 6 commits May 26, 2025 09:07
Hello All
This is daeoh from IVH

My company make a iSuite25 for FMI simulation tool.
So, I hope to add a tool list. 
I was recommended by Christian Bertsch
Change a json file
I remove a features
@t-sommer t-sommer merged commit 58ede63 into modelica:main May 26, 2025
2 checks passed
@chrbertsch
Copy link
Collaborator

@t-sommer : the update of the tools list was not successfull, see https://github.com/modelica/fmi-standard.org/actions/runs/15249420285. Could you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants