Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QYOG-79): 모집중인 동아리 UI #61

Merged
merged 10 commits into from
Feb 18, 2024
Merged

Conversation

soonki-98
Copy link
Member

@soonki-98 soonki-98 commented Feb 18, 2024

Pull Request

티켓

QYOG-79

작업 내용

  • Converter class 추가 (변환 관련된 기능은 해당 클래스에 정의 부탁드립니다.)
  • Footer 추가
  • 모집중인 동아리 UI 작성
  • yarn test 실행시 png 파일 import 시 발생하는 에러 수정

스크린샷

image

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dongurami-front-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2024 8:23am

@soonki-98 soonki-98 requested review from jsj1510 and pho9902 February 18, 2024 08:24
@soonki-98 soonki-98 self-assigned this Feb 18, 2024
@soonki-98 soonki-98 added the ✨ Feature 기능 추가 수정 삭제 등의 작업 label Feb 18, 2024
@@ -7,11 +7,16 @@ module.exports = {
"^.+\\.tsx?$": ["ts-jest", { tsconfig: "./tsconfig.test.json" }],
"^.+\\.jsx?$": "babel-jest",
"^.+\\.svg$": "jest-transformer-svg",
"^.+\\.js$": "babel-jest",
".+\\.(css|styl|less|sass|scss|png|jpg|ttf|woff|woff2)$":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10~12번 줄로 image test 오류나는거 수정하는건가?
맞으면 자료 어디서 봤는지 공유가능해?

@@ -17,5 +17,8 @@ jobs:
- name: Install Dependencies
run: yarn install

- name: Clear Cache
run: npx jest --clearCache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캐쉬 클리어 이번에 추가된 이유가 뭐야?

@soonki-98 soonki-98 merged commit 0f9ba81 into develop Feb 18, 2024
4 checks passed
@soonki-98 soonki-98 deleted the feature/skmin/QYOG-79 branch February 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 추가 수정 삭제 등의 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants