QYOG-38 소셜 회원가입 fix (1차) #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrgks6221
reviewed
Feb 4, 2024
| @@ -0,0 +1,52 @@ | |||
| import { MigrationInterface, QueryRunner, TableColumn } from "typeorm" | |||
|
|
|||
| export class UserEmailNullable1706878330599 implements MigrationInterface { | |||
| import moment from 'moment'; | ||
| import * as crypto from 'crypto'; | ||
|
|
||
| @Injectable() |
There was a problem hiding this comment.
별도의 서비스를 만들어서 관리하는거보다는 usersService에 private method로 관리되는게 나들거같아요
| ) {} | ||
|
|
||
| async create(createUserRequestBodyDto: CreateUserRequestBodyDto) { | ||
| async create({ snsId, loginType }: Pick<CreateUserDto, 'snsId' | 'loginType'>) { |
There was a problem hiding this comment.
일단 프론트측 테스트때문에 돌아가게만 만들어진거같은데 어떤 작업 추가로 해야하는지 각 메서드들 위에 주석으로 달아주시겠어요
jsdoc의 todo 형태로 다시면 됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
기존 머지된 소셜 회원가입에서 null 허용이 똑바로 되지 않음
To Reviewer
user_${timestamp}_${randomString}이렇게되어 약간 김.Reference Link
Related Issue Link
https://dongurami.atlassian.net/browse/QYOG-38
API