Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transactional 데코레이터로 transaction 관리하게 변경 #134

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

rrgks6221
Copy link
Member

@rrgks6221 rrgks6221 commented Feb 11, 2024

JIRA

QYOG-63

Description

transactional 데코레이터로 transaction 관리하게 변경

To Reviewer

  • 앞으로 트랜젝션 관리는 transactional 데코레이터로 필요한 곳에서만 제어하기로 하겠습니다.
  • 테스트코드는 나중에 관리하도록할게요

Reference Link

transactional readme

Related Issue Link

API

Method Path 설명 작업(추가, 수정, 삭제)

@rrgks6221 rrgks6221 added the Refactor 코드 수정(기능상의 수정이 없는 경우) label Feb 11, 2024
@rrgks6221 rrgks6221 self-assigned this Feb 11, 2024
await queryRunner.commitTransaction();
const updateResult = await this.noticePostRepository.update(
{ id: noticePostId },
{ status: NoticePostStatus.Remove },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deletedAt: new Date()도 해주셔야 될 것 같아요ㅋ

hobiJeong
hobiJeong previously approved these changes Feb 11, 2024
Copy link
Collaborator

@hobiJeong hobiJeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이슈 링크가 안타져오

@rrgks6221
Copy link
Member Author

충돌해결

@rrgks6221
Copy link
Member Author

이슈 링크가 안타져오

수정했습니다.

@rrgks6221 rrgks6221 merged commit 6dc5875 into develop Feb 11, 2024
@rrgks6221 rrgks6221 deleted the refactor/QYOG-63 branch February 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 코드 수정(기능상의 수정이 없는 경우)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants