Follow up to 16322: Fix non-existent snippet tags being broken up by an @ tag #16682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with default value not working when prop set is specified in an Element call
Fix code quality issue
|
Thanks for taking over the PR and working on it some more. It is indeed something that takes a while to figure out - it took me like 3 days of work to get to that PR which fixed some issues, but left the one I couldn't sort out. I've added a note to my to do list to review and dig back into this to give it a proper review. It may take me a few weeks but is on the list. |
Hey @Mark-H any chance you might be able to take another peek at this one, since you were the OP? :) |
|
@Mark-H - It's been a few few weeks (just giving you a hard time). It'd be great to get all that work that mainly you did implemented ;-) ... can you carve out some time to check this soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Identifies and fixes a problem present in the getPropertySet method where the Element name is re-set, but without the necessary colon between the actual Element name and the rest of its tag.
Why It's Needed / How to Test
See PR #16322
Note
This is by and large the result of @Mark-H's work -- although it did take the better part of a night to track down the issue he was asking for help on ;-)