Skip to content

Conversation

tastyqbit
Copy link

Specifically in react native navigation, the vertical offset is wrong on android (#106). This commit allows passing in an async function that can be executed at runtime to decide vertical offset based on the specific devices statusbar and topbar height (in react native navigations case, using await Navigation.constants() )

Specifically in react native navigation, the vertical offset is wrong on android (mohebifar#106). This commit allows passing in an async function that can be executed at runtime to decide vertical offset based on the specific devices statusbar and topbar height (in react native navigations case, using await Navigation.constants() )
@mohebifar
Copy link
Owner

Hey @tastyqbit , could you possibly add some explanation to the docs please?

@tastyqbit
Copy link
Author

@mohebifar done :)

@mohebifar
Copy link
Owner

LGTM, there is just some lint issues that need to be fixed before merging

@tastyqbit
Copy link
Author

How can I see what the linter errors are? I can't see it in checks

@mohebifar
Copy link
Owner

Here's the failing build:

https://travis-ci.org/github/mohebifar/react-native-copilot/builds/698862581

you can also run npm run lint locally to run the linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants