Dev remove cordova loader #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-hirose
reviewed
Jun 3, 2024
| @@ -12,11 +12,17 @@ | |||
| </style> | |||
| <script type="module" crossorigin src="./assets/index.js"></script> | |||
| <link rel="stylesheet" href="./assets/index.css"> | |||
| <script type="module">import.meta.url;import("_").catch(()=>1);async function* g(){};if(location.protocol!="file:"){window.__vite_is_modern_browser=true}</script> | |||
There was a problem hiding this comment.
@knaito-asial このテンプレートだけこの www/index.html の修正点違うのはなんでです？
There was a problem hiding this comment.
元のテンプレートがおかしいと思います。修正後は
修正後のvue3 navigationテンプレート
https://github.com/monaca-templates/onsenui-v2-vue3-navigation/blob/dev_remove_cordova_loader/www/index.html
修正後のvue3 tabbarテンプレート
https://github.com/monaca-templates/onsenui-v2-vue3-tabbar/blob/dev_remove_cordova_loader/www/index.html
で、どちらも同じになります。
as-hirose
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
www/components/cordova-loaderとcore-utilsを削除
<script src="cordova.js"></script>www/components/loader.jsを修正(コメントのみにする)
src/index.htmlにcordova.jsの読み込みを追加
npm run build