Added support for the create_wallet rpc method #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are any maintainers still active? |
h4sh3d
approved these changes
Oct 24, 2023
Yes, but don't expect next day response time 😄 |
|
Nice, great to see that y'all are active. I took a look at the code I wrote and I used a pretty misleading name for the return data of the RPC call. Instead of CreateWallet I'll change it to AccountCreation, following the WalletCreation naming convention previously used. Since I'm also adding support for get_tx_proof and check_tx_proof, I'll add a name change with that pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test I added only checks if the account_index is >=1 since before the implementation of the create_wallet method all wallets were limited to using addresses with account_index = 0. I'm new to the monero ecosystem and its inner working so if there's anything you see that is wrong feel free to change it or message me and I'll do the edit.