CDRIVER-5945 mongoc_collection_create_indexes_with_opts does not apply write command behavior #2099
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia-Garland
changed the title
Julia-Garland
requested review from
mdb-ad and
vector-of-bool
and removed request for
mdb-ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mongoc_collection_create_indexes_with_optsusesmongoc_client_command_with_optsrather thanmongoc_collection_write_command_with_opts. As a result, write command behavior is not applied:These changes now call
mongoc_collection_write_command_with_opts.A test was added to reproduce the errors in the original code and confirm that write command behavior is fixed with the correct call.