CSHARP-5708: Avoid disposal of OperationContext shared in transaction #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested review from
BorisDog and
adelinowona
and removed request for
papafe
sanych-sun
commented
Aug 21, 2025
|
|
||
| if (operationContext.IsRootContextTimeoutConfigured()) | ||
| { | ||
| writeConcern = writeConcern.With(wTimeout: null); |
There was a problem hiding this comment.
We should not use wTimeout if CSOT timeout is configured.
BorisDog
requested changes
Aug 22, 2025
| @@ -99,6 +111,12 @@ public void Dispose() | |||
| _combinedCancellationTokenSource?.Dispose(); | |||
| } | |||
|
|
|||
| public OperationContext Fork() | |||
There was a problem hiding this comment.
minor:
public OperationContext Fork() =>
new(...) { RootContext... }
| [InlineData(100, 0)] | ||
| [InlineData(100, 100)] | ||
| [InlineData(100, 1000)] | ||
| public void Elapsed_should_calculate(int timeoutMs, int elapsedMs) |
There was a problem hiding this comment.
minor: calculate what (also in other methods)?
BorisDog
previously approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.