PHPLIB-1708 Cast empty KMS provider into an object #1757
Merged
+41
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GromNaN
force-pushed
the
PHPLIB-1708
branch
2 times, most recently
from
1c52490 to
d96aa71
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // The server requires an empty document for automatic credentials. | ||
| if (isset($options['kmsProviders']) && is_array($options['kmsProviders'])) { | ||
| foreach ($options['kmsProviders'] as $name => $provider) { |
Check notice
Code scanning / Psalm
MixedAssignment Note
|
Fixed in Doctrine MongoDB ODM Bundle by setting a DI |
GromNaN
commented
Aug 19, 2025
jmikola
reviewed
Aug 19, 2025
| @@ -37,6 +37,18 @@ public function testConstructorAutoEncryptionOpts(): void | |||
| new Client(static::getUri(), [], ['autoEncryption' => $autoEncryptionOpts]); | |||
| } | |||
|
|
|||
| #[DoesNotPerformAssertions] | |||
| public function testConstructorEmptyKmsProvider(): void | |||
There was a problem hiding this comment.
Would this test have failed without the above patch? If not, is anything being tested at all?
There was a problem hiding this comment.
Yes:
MongoDB\Driver\Exception\EncryptionException: expected BSON document for field: gcp
jmikola
reviewed
Aug 19, 2025
jmikola
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1708
For some KMS providers, all options can be omitted. The authentication is done using the env var or the system.
https://github.com/mongodb/specifications/blob/master/source/client-side-encryption/client-side-encryption.md#credentialproviders
The approach in doctrine/mongodb-odm#2801 is not sufficient because Symfony is not able to dump the empty object instance into the container.