Skip to content

Conversation

paulinevos
Copy link
Contributor

@paulinevos paulinevos commented Aug 26, 2025

As it's covered by the drivers-evergreen-tools submodule now.

@paulinevos paulinevos requested a review from a team as a code owner August 26, 2025 11:39
@paulinevos paulinevos requested a review from GromNaN August 26, 2025 11:39
As it seems to be covered by the `drivers-evergreen-tools` submodule,
which is loaded in evergreen functions and GH actions (added in PR
`mongodb#1584`)
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.72%. Comparing base (297b71a) to head (e5c51ce).
⚠️ Report is 1 commits behind head on v2.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x    #1766   +/-   ##
=========================================
  Coverage     87.72%   87.72%           
  Complexity     3190     3190           
=========================================
  Files           424      424           
  Lines          6348     6348           
=========================================
  Hits           5569     5569           
  Misses          779      779           
Flag Coverage Δ
6.0-replica_set 85.68% <ø> (ø)
6.0-server 81.69% <ø> (ø)
6.0-sharded_cluster 85.27% <ø> (ø)
8.0-replica_set 87.64% <ø> (ø)
8.0-server 82.57% <ø> (ø)
8.0-sharded_cluster 87.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulinevos paulinevos force-pushed the 1710_remove-ocsp-dir branch from f7c5a92 to 04d7a27 Compare August 26, 2025 11:45
@jmikola
Copy link
Member

jmikola commented Aug 26, 2025

I think there are some additional changes that can be applied and tested:

  • .evergreen/config/functions.yml refers to the local x509gen directory several times. Those references can be changed to tests/drivers-evergreen-tools/.evergreen/x509gen.
  • .evergreen/orchestration only contains a single basic.json file for a sharded cluster, and that doesn't appear to be referenced anywhere.
  • .evergreen/auth_aws doesn't appear to be referenced.

@paulinevos
Copy link
Contributor Author

@jmikola What I don't understand re: the x509gen references is that they're from the same exact commit as references to x509gen in the submodule a few lines later. That makes me feel like maybe there's a reason that points to the local ones

Its contents don't seem to be used
It doesn't appear to be referenced locally anymore, only internally in the
drivers-evergreen-tools submodule
@paulinevos paulinevos changed the title Remove .evergreen/ocsp directory PHPLIB-1710: Remove .evergreen/ocsp directory Aug 26, 2025
@paulinevos
Copy link
Contributor Author

@jmikola Oh actually, they aren't references to the local one at all:

cd ${DRIVERS_TOOLS}/.evergreen/csfle

I'll see if they're referenced anywhere else and otherwise remove

There's no need for it locally as it's covered by
the `drivers-everygreen-tools` submodule
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed the cd command in functions.yml.

Changes LGTM. I'll defer to you on the tests.yml change.

And please revise the PR title before squash-merging, since the PR addresses more than just OCSP.

@paulinevos paulinevos changed the title PHPLIB-1710: Remove .evergreen/ocsp directory PHPLIB-1710: Remove dead local .evergreen config Aug 27, 2025
@paulinevos paulinevos merged commit 45c88ac into mongodb:v2.x Aug 27, 2025
32 checks passed
@paulinevos paulinevos deleted the 1710_remove-ocsp-dir branch August 27, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants