[CLOUDP-343558] Run helm chart-testing tool ct as part of CI (lint_repo)
#450
Conversation
Somehow all the efforts to set path env var using below code
```
- command: subprocess.exec
type: test
params:
add_to_path:
- ${workdir}/bin
- ${workdir}/venv/bin
working_dir: src/github.com/mongodb/mongodb-kubernetes
binary: scripts/evergreen/lint_helm_chart.sh
```
I even tried to remove `subprocess.exec` and use `shell.exec` and used
`env:` for params, that didn't work as well. that's why we are finally
settling on to setting path at the lowest level. Otherwise `ct` CLI resulted
into `yamale` and `yamllint` are not found.
viveksinghggits
added
the
skip-changelog
MCK 1.3.1 Release Notes |
There was a problem hiding this comment.
Changes look good, still I have one general ask.
When we add or change logic in our linting requirements we should also consider adding them to .githooks/pre-commit. Otherwise there is no way locally to lint the helm charts.
Secondly we should make scripts that are run in EVG CI easy to run locally as well. I wouldn't put them in scripts/evergreen/ directory, but in scripts/helm and make them available for developers. I think also .githooks/pre-commit takes care of installing all prerequisite applications.
| @@ -420,3 +420,8 @@ prepare-local-olm-e2e: | |||
|
|
|||
| prepare-operator-configmap: # prepares the local environment to run a local operator | |||
| source scripts/dev/set_env_context.sh && source scripts/funcs/printing && source scripts/funcs/operator_deployment && prepare_operator_config_map "$(kubectl config current-context)" | |||
|
|
|||
| # Lint the helm chart using helm chart-testing tool (`ct`) using the default configuration available at `helm_chart/tests/schemas/` | |||
| lint-chart: | |||
There was a problem hiding this comment.
what about target for installing chart-testing locally?
There was a problem hiding this comment.
both scripts should not be in scripts/evergreen/ dir, they can be used outside of evg
Summary
Whenever we raised PR in to helm chart repo CI failed there because we had linting issues in our helm chart. A previous PR that I raised fixed the linting problem. But we should have a linting mechanism in our CI that would consistently check if we have made any mistake in our charts. This PR does that.
The
chart_schema.yamlandlintconf.yamlare the default yaml files using whichctshould be run. Andctis the tool that is used for linting in our helm charts repo.Proof of Work
Passing
lint_repotask here https://spruce.mongodb.com/version/68c43aae1d5d5d000770c624/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC and in this PR as well.Checklist
skip-changeloglabel if not needed