Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async support #51

Merged
merged 2 commits into from
Jan 15, 2025
Merged

add async support #51

merged 2 commits into from
Jan 15, 2025

Conversation

tonyfettes
Copy link
Contributor

No description provided.

Copy link

peter-jerry-ye-code-review bot commented Jan 15, 2025

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations from the provided git diff output:

  1. Inconsistent Handling of apply_operator in apply_expression:

    • In the apply_expression rule, the apply_operator is now used instead of directly including ! or question_operator. However, in the test files (asi.txt, expression.txt, and test.txt), the apply_operator is sometimes used, but in other cases, the question_operator is still directly referenced. This inconsistency might lead to confusion or errors in parsing. Ensure that all instances are updated to use apply_operator consistently.
  2. Potential Missing apply_operator in test.txt:

    • In test.txt, there is a line with (apply_operator) but no associated value or operator. This might be a typo or an incomplete implementation. Verify if this is intentional or if an operator (like ! or !!) should be specified here.
  3. New async Keyword Integration:

    • The async keyword has been added to function definitions and lambda expressions. While this is a valid addition, ensure that all related test cases and documentation are updated to reflect this change. Specifically, check if the async keyword is correctly handled in all contexts, such as in function_definition, anonymous_lambda_expression, and function_type.

These observations highlight areas where further review or testing might be necessary to ensure consistency and correctness in the grammar and parsing logic.

@tonyfettes tonyfettes merged commit b8b3a5c into moonbitlang:main Jan 15, 2025
1 check passed
@tonyfettes tonyfettes deleted the async branch January 15, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant