Skip to content

Merge FDC3 2.0 Conformance Feature Branch #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Mar 6, 2025

This PR merges the changes that have been implemented so that ComposeUI is an FDC3 2.0 compliant Desktop Agent.
This feature branch also includes the fixes and improvements that have been introduced after the product has earned the compliance badge.

lilla28 and others added 30 commits September 25, 2024 16:49
feat(fdc3) - Implement open and raiseIntentForContext
fix(examples) - Revert back the apps.json file
 - Marked Context nullable in RaiseIntentRequest
 - Removed unnecessary string interpolation from Fdc3DesktopAgentErrors
 - Added TargetInstanceUnavailable to Fdc3DesktopAgentErrors
 - Added TargetAppUnavailable to ThrowHelper and fixed the error message in TargetInstanceUnavailable
Handle context data correctly in Intents
Filter by appid on RaiseIntentForContext
.csproj file updates net6.0 => net8.0
Nuget package updates
Convert to common Directory.Build.props
Fix for unit tests
Common TargetFramework for vanilla net8.0 projects
Fdc3 packages reset to 2.0.0
Prevent automatic Nuget package update to .net9
Updated the .NET version in the project from 6.0.x to 8.0.x.
Modified multiple sections in README.md to reflect this change,
including the framework version table, development setup
prerequisites, and the path to the locally compiled shell binary.
Updated the .NET Runtime link in the prerequisites for the shell
to point to the .NET 8.0.12 version instead of 6.0.16.
* fix(close) - Fixing window.close override as injecting scripts in the NavigationStarting event sometimes prevents the execution of the window.close();  fix(examples) - Fixing examples not loading up on fdc3Ready event as it's triggered before the eventhandler being added; fix(unit-tests) - Fixing failing unit tests
…t when calling handler after returning back the context listener object (#911)
Updated the `continuous-integration.yml` and `release.yml` files to use .NET version 8.0.x instead of 6.0.x. Adjusted the path for uploading shell binaries to `net8.0-windows`.
Update CI and release configs to .NET 8.0.x
…ranch

* fix(fdc3-unit-tests) - Fixing FDC3 Typescript lib unit test caused by the downgrade

* fix(DA.sln-tests) - Fixing Unit/EndToEnd tests

* fix(workflow) - Add CI PR run for the conformance branch

* fix(tests) - Add nullable for fields

* fix(process-explorer) - Add Skip attribute and reasons
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 61.50628% with 368 lines in your changes missing coverage. Please review.

Project coverage is 66.8%. Comparing base (11696de) to head (3532784).

Files with missing lines Patch % Lines
...Stanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs 69.1% 45 Missing and 17 partials ⚠️
...tnet/Shell/Fdc3/ResolverUI/Fdc3ResolverUIWindow.cs 0.0% 53 Missing ⚠️
src/shell/dotnet/Shell/Modules/ModuleService.cs 0.0% 31 Missing ⚠️
...re/Internal/ResolverUIMessageRouterCommunicator.cs 23.6% 29 Missing ⚠️
...3/src/infrastructure/MessageRouterIntentsClient.ts 10.7% 25 Missing ⚠️
...l/Fdc3/ResolverUI/Fdc3ResolverUIIntentViewModel.cs 0.0% 18 Missing ⚠️
...topAgent/Infrastructure/Internal/IntentResolver.cs 70.6% 12 Missing and 5 partials ⚠️
...dc3/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 68.6% 16 Missing ⚠️
...dc3/src/infrastructure/ComposeUIContextListener.ts 54.2% 16 Missing ⚠️
...net/Shell/Fdc3/ResolverUI/ResolverUIIntent.xaml.cs 0.0% 14 Missing ⚠️
... and 23 more

❌ Your patch check has failed because the patch coverage (61.5%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #981     +/-   ##
=======================================
- Coverage   67.9%   66.8%   -1.1%     
=======================================
  Files        308     327     +19     
  Lines       9131    9719    +588     
  Branches    1053    1058      +5     
=======================================
+ Hits        6200    6501    +301     
- Misses      2701    2966    +265     
- Partials     230     252     +22     
Files with missing lines Coverage Δ
...poseUI.DesktopAgent/Contracts/FindIntentRequest.cs 100.0% <100.0%> (ø)
...ktopAgent/Contracts/FindIntentsByContextRequest.cs 100.0% <100.0%> (ø)
....DesktopAgent/Contracts/GetIntentResultResponse.cs 87.5% <100.0%> (ø)
...sktopAgent/Contracts/GetOpenedAppContextRequest.cs 100.0% <100.0%> (ø)
...ey.ComposeUI.DesktopAgent/Contracts/OpenRequest.cs 100.0% <100.0%> (ø)
...y.ComposeUI.DesktopAgent/Contracts/OpenResponse.cs 100.0% <100.0%> (ø)
...topAgent/Contracts/RaiseIntentForContextRequest.cs 100.0% <100.0%> (ø)
...oseUI.DesktopAgent/Contracts/RaiseIntentRequest.cs 100.0% <100.0%> (ø)
...topAgent/Contracts/RaiseIntentResolutionRequest.cs 100.0% <100.0%> (ø)
...DesktopAgent/Contracts/StoreIntentResultRequest.cs 100.0% <100.0%> (ø)
... and 43 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kruplm kruplm force-pushed the feat/fdc3-2_0-conformance branch from d7b606c to 0929462 Compare March 11, 2025 16:37
@kruplm kruplm marked this pull request as ready for review March 11, 2025 17:15
psmulovics
psmulovics previously approved these changes Mar 12, 2025
@kruplm kruplm force-pushed the feat/fdc3-2_0-conformance branch from eb6bf1e to b4c7b00 Compare March 12, 2025 16:06
lilla28
lilla28 previously approved these changes Mar 12, 2025
psmulovics
psmulovics previously approved these changes Mar 17, 2025
ZKRobi
ZKRobi previously approved these changes Mar 19, 2025
lilla28 and others added 3 commits March 19, 2025 15:20
…s when rasing intent via the RaiseIntent or RaiseIntentForContext
… to be passed as null; correct extension class namespace
…Directory, removed duplicated publishing of the raised intents for handling with the right intent listener, added duplicated check on channel ids

fix/feat(fdc3) - Checking the Interop.Intents.Raises section from AppDirectory, removed duplicated publishing of the raised intents for handling with the right intent listener, added duplicated check on channel ids
@lilla28 lilla28 dismissed stale reviews from ZKRobi, psmulovics, and themself via fcd53b5 March 19, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants