-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
taskcluster/ci/build/kind.yml
Outdated
@@ -0,0 +1,39 @@ | |||
# This Source Code Form is subject to the terms of the Mozilla Public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of mozilla-extensions/xpi-template#5 , we no longer need to copy in the taskcluster/
directory, as we clone xpi-template
and use the files from the given repo and branch defined in .taskcluster.yml
. We only need the files specified here. It won't hurt the infrastructure to copy the taskcluster
directory into this repository, but we won't use it, so it may add clutter and/or cause confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I've removed the unecessary files. I'm not clear if I need to specify the files to be included in the addon somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good. All the comments are informative, not requesting changes.
taskgraph: | ||
branch: taskgraph | ||
revision: 8051b20c975711d4ce09537285cef7451d043d8b | ||
template: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes needed, just letting you know this block tells taskcluster which repo and branch to use for the taskcluster/
files.
TEMPLATE_BASE_REPOSITORY: '${template.repo}' | ||
TEMPLATE_HEAD_REPOSITORY: '${template.repo}' | ||
TEMPLATE_HEAD_REV: '${template.branch}' | ||
TEMPLATE_HEAD_REF: '${template.branch}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just FYI, the template
files specified above get surfaced as environment variables here.
TASKGRAPH_HEAD_REPOSITORY: https://hg.mozilla.org/ci/${taskgraph.branch} | ||
TASKGRAPH_HEAD_REV: '${taskgraph.revision}' | ||
TASKGRAPH_REPOSITORY_TYPE: hg | ||
REPOSITORIES: {$json: {xpi: "XPI Manifest", taskgraph: "Taskgraph", template: "XPI Template"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also FYI, this lets taskgraph know we want to clone multiple repos
command: | ||
- /usr/local/bin/run-task | ||
- '--xpi-checkout=/builds/worker/checkouts/src' | ||
- '--template-checkout=/builds/worker/checkouts/template' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fyi, we specify where to check out the template files here.
PIP_IGNORE_INSTALLED=0 pip install --user /builds/worker/checkouts/taskgraph && | ||
cd /builds/worker/checkouts/src && | ||
rm -rf taskcluster && | ||
ln -s /builds/worker/checkouts/template/taskcluster taskcluster && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we softlink taskcluster into the source repo here.
@escapewindow mind looking over this and let me know what else needs to change? All I've done is set the signature type to privileged.