Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared tc dir #5
Shared tc dir #5
Changes from 25 commits
939744e
14e14c0
7794c5a
5413569
2ceb953
faa2c7e
68feeb3
ac74b17
d69630a
c19cefb
cd6002c
82ab504
f7b3f3a
6e3938c
800d4fc
b8b9686
ca54111
2068ecb
9a2e2ec
0e5a9d7
08431f1
68d1fb9
7bd92b9
41b3133
b744e36
d196347
94903b9
c511f4e
202ec73
85da87f
dbe107d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these two comments are regarding the
xpi-manifest
repository. I'll open a PR there to address these.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mozilla-extensions/xpi-manifest#32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be updated (or removed, I'm not sure how much value it is providing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mozilla-extensions/xpi-manifest#32 . (The tip of this PR doesn't have any
taskcluster/docker
; we use the docker image indexes fromxpi-manifest
. I tried copying the docker directory as part of trying to resolve the--root
bustage.)