Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fenix quarantine #701

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Import fenix quarantine #701

merged 1 commit into from
Oct 19, 2023

Conversation

mozilla-pontoon
Copy link
Collaborator

Import fenix quarantine

@mozilla-pontoon mozilla-pontoon requested a review from a team as a code owner October 16, 2023 15:12
@mozilla-pontoon mozilla-pontoon added the l10n-bot Pull request created by automation label Oct 16, 2023
@mozilla-pontoon
Copy link
Collaborator Author

Run ID: 6535627772
Authors: @sarah541

TOML file: firefox.toml

File: mozilla-mobile/fenix/app/src/main/res/values/strings.xml

ID: juno_onboarding_enable_notifications_description_nimbus_2
Text: Securely send tabs between your devices and discover other privacy features in Firefox.
Errors:

  • Hard-coded brand Firefox. Use a variable instead.

ID: juno_onboarding_enable_notifications_title_nimbus_2
Text: Notifications help you stay safer with Firefox
Errors:

  • Hard-coded brand Firefox. Use a variable instead.

ID: juno_onboarding_sign_in_description_2
Text: When you\'re signed in and synced, you\'re safer. Firefox encrypts your passwords, bookmarks, and more.
Errors:

  • Incorrect straight quote character '. use instead.
  • Hard-coded brand Firefox. Use a variable instead.

Total errors not yet reported: 4

@sarah541
Copy link
Contributor

sarah541 commented Oct 16, 2023

Run ID: 6535627772 Authors: @sarah541

TOML file: firefox.toml

File: mozilla-mobile/fenix/app/src/main/res/values/strings.xml

ID: juno_onboarding_enable_notifications_description_nimbus_2 Text: Securely send tabs between your devices and discover other privacy features in Firefox. Errors:

* Hard-coded brand `Firefox`. Use a variable instead.

ID: juno_onboarding_enable_notifications_title_nimbus_2 Text: Notifications help you stay safer with Firefox Errors:

* Hard-coded brand `Firefox`. Use a variable instead.

ID: juno_onboarding_sign_in_description_2 Text: When you\'re signed in and synced, you\'re safer. Firefox encrypts your passwords, bookmarks, and more. Errors:

* Incorrect straight quote character `'`. use `’` instead.

* Hard-coded brand `Firefox`. Use a variable instead.

Total errors not yet reported: 4

As for the error : Text: When you\'re signed in and synced, you\'re safer. Firefox encrypts your passwords, bookmarks, and more., has been fixed here
And for the errors that say : Hard-coded brand Firefox. Use a variable instead., Nimbus experiments do not support string placeholders. That's why the comment has been added Note: The word "Firefox" should NOT be translated

@mozilla-pontoon
Copy link
Collaborator Author

Run ID: 6549241572
Authors: @ekager @tiftran

TOML file: firefox.toml

File: mozilla-mobile/fenix/app/src/main/res/values/strings.xml

ID: preference_search_address_bar_fx_suggest
Text: Address bar - Firefox Suggest
Errors:

  • Hard-coded brand Firefox. Use a variable instead.

ID: preference_search_learn_about_fx_suggest
Text: Learn more about Firefox Suggest
Errors:

  • Hard-coded brand Firefox. Use a variable instead.

Total errors not yet reported: 2

@tiftran
Copy link

tiftran commented Oct 18, 2023

Hi @Delphine! I was advised to tag you to get your opinion regarding "Firefox Suggest". Since Firefox Suggest is a branch and we don't want be "Nightly Suggest" or "Firefox Beta Suggest". What is the right way to achieve that?

@Delphine
Copy link
Contributor

Delphine commented Oct 18, 2023

Hi @tiftran! Sorry, I'm not sure I understand the question.
Firefox Suggest has been called "Firefox Suggest" across platforms at this point: https://transvision.mozfr.org/?recherche=Firefox+Suggest&repo=all_projects&sourcelocale=en-US&locale=fr&search_type=strings
Is there a reason we wouldn't want to call it this way?

@mozilla-pontoon mozilla-pontoon force-pushed the fenix_l10n_updates branch 2 times, most recently from c75dfb0 to f65499c Compare October 19, 2023 18:09
@Delphine
Copy link
Contributor

Update: Fixed the linter/brand part. Now doing another review pass

@Delphine Delphine merged commit c9d193d into main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-bot Pull request created by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants