This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1839075 - Corrects timeout duration for CopyDownloadFeature #4737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just triaging and thought we should probably fix this |
|
@t-p-white Friendly bump on this review. |
t-p-white
suggested changes
Mar 4, 2024
There was a problem hiding this comment.
Apologies, this PR totally fell off my radar. This 1 minute value is correct, it's actually the comment which is wrong, see #948 (comment) for context
t-p-white
reviewed
Mar 5, 2024
| @@ -62,7 +62,7 @@ class CopyDownloadFeature( | |||
| /** | |||
| * At most time to allow for the file to be downloaded. | |||
| */ | |||
| private val operationTimeoutMs by lazy { TimeUnit.MINUTES.toMinutes(1) } | |||
| private val operationTimeoutMs by lazy { TimeUnit.SECONDS.toMillis(1) } | |||
There was a problem hiding this comment.
Suggested change
| private val operationTimeoutMs by lazy { TimeUnit.SECONDS.toMillis(1) } | |
| private val operationTimeoutMs by lazy { TimeUnit.MINUTES.toMillis(1) } |
|
We have moved our firefox-android repo over to mozilla-central. Please feel free to reopen a new PR against the new repo. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience. For more information, please see https://github.com/mozilla-mobile/firefox-android/wiki#upcoming-migration-to-mozilla-central. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous line always returned
1. Now it will return1000Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1839075