Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Revert "Bug 1812843 - Increased the width for a CustomTabsToolbarFeature action button" #5314

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Revert "Bug 1812843 - Increased the width for a CustomTabsToolbarFeature action button" #5314

merged 2 commits into from
Jan 29, 2024

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Jan 26, 2024 •
edited by github-actions bot
Loading

@t-p-white t-p-white requested a review from MozillaNoah January 26, 2024 10:55
@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jan 26, 2024
@t-p-white t-p-white requested a review from a team January 26, 2024 10:55
MozillaNoah
MozillaNoah approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big sad

@github-actions github-actions bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 26, 2024
@t-p-white
Copy link
Contributor Author

@MozillaNoah, yep! Have reopened the OG bug.

@t-p-white t-p-white added the 🛬 needs landing PRs that are ready to land label Jan 29, 2024
@dsmithpadilla
Copy link
Contributor

@t-p-white this wont land due to ci failures in lint-ktlint-android-components

@t-p-white t-p-white force-pushed the revert-5141-1812843 branch from 19cf82f to b850179 Compare January 29, 2024 15:09
@t-p-white t-p-white force-pushed the revert-5141-1812843 branch from b850179 to 445f01c Compare January 29, 2024 15:14
@t-p-white
Copy link
Contributor Author

@dsmithpadilla thanks for the prompt. Strange as this was a revert commit, I wonder if these tests were 'ok' with the previous ktlint checks but not the current config. Have manually updated the affected lines (inCustomTabsToolbarFeatureTest)

@mergify mergify bot merged commit 39e6ff3 into main Jan 29, 2024
63 checks passed
@rvandermeulen rvandermeulen deleted the revert-5141-1812843 branch January 29, 2024 17:25
@pascalchevrel
Copy link
Contributor

@mergify backport releases_v123

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024 •
edited
Loading

backport releases_v123

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
pascalchevrel pushed a commit that referenced this pull request Jan 31, 2024
@mergify @t-p-white
Revert "Bug 1812843 - Increased the width for a CustomTabsToolbarFeat…
d0d69bc 
…ure action button" (backport #5314) (#5379)

(cherry picked from commit 39e6ff3)

Co-authored-by: t-p-white <1833156+t-p-white@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MozillaNoah MozillaNoah MozillaNoah approved these changes

Assignees

@MozillaNoah MozillaNoah

Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-p-white @dsmithpadilla @pascalchevrel @MozillaNoah