Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1876734 - Add more test logs to ComposeTopSitesRobot #5316

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

AndiAJ
Copy link
Contributor

@AndiAJ AndiAJ commented Jan 26, 2024

Summary:

  • As part of the Android test hardening, to ease the debugging process, I've added test logs to the ComposeTabDrawerRobot
  • Removed deleteTopSiteFromHistory as it's doing the same thing as removeTopSite and refactored the UI test

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1876734

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Jan 26, 2024
@AndiAJ AndiAJ force-pushed the composeTopSitesRobot branch from edf5c0e to 1c3c006 Compare January 30, 2024 10:30
@AndiAJ AndiAJ marked this pull request as ready for review January 30, 2024 11:04
@AndiAJ AndiAJ requested a review from sv-ohorvath January 30, 2024 11:04
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Jan 30, 2024
@AndiAJ AndiAJ requested a review from jjSDET January 30, 2024 11:05
@AndiAJ AndiAJ assigned AndiAJ and unassigned sv-ohorvath and jjSDET Jan 30, 2024
Copy link
Contributor

@jjSDET jjSDET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndiAJ AndiAJ added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 31, 2024
@AndiAJ AndiAJ closed this Jan 31, 2024
@AndiAJ AndiAJ reopened this Jan 31, 2024
@github-actions github-actions bot added the approved PR that has been approved label Jan 31, 2024
@mergify mergify bot merged commit 9f43302 into mozilla-mobile:main Jan 31, 2024
23 checks passed
@AndiAJ AndiAJ deleted the composeTopSitesRobot branch January 31, 2024 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants