This repository was archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1876752 - Reordered preferences in SettingsFragment to match the UI layout
#5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozillaNoah
reviewed
Jan 26, 2024
| @@ -42,10 +41,8 @@ | |||
| <string name="pref_key_override_amo_user" translatable="false">pref_key_override_amo_user</string> | |||
| <string name="pref_key_override_amo_collection" translatable="false">pref_key_override_amo_collection</string> | |||
| <string name="pref_key_enable_gecko_logs" translatable="false">pref_key_enable_gecko_logs</string> | |||
| <string name="pref_key_help" translatable="false">pref_key_help</string> | |||
There was a problem hiding this comment.
aren't you cleaning these up in #5320?
There was a problem hiding this comment.
@MozillaNoah yep! This PR depends on that issue, which is why it's included as a commit here. I wanted to keep the 2 refactors separate 🙂
There was a problem hiding this comment.
I really need to have coffee before doing your PRs 😂
Comment on lines
358
to
365
| // Only displayed when secret settings are enabled | ||
| resources.getString(R.string.pref_key_install_local_addon) -> { | ||
| addonFilePicker.launch() | ||
| null | ||
| } | ||
| // Only displayed when secret settings are enabled |
There was a problem hiding this comment.
Could we also add a new line in-between for these since we did it for everything else? This also needs to happen below so you may need to go through your changes again.
There was a problem hiding this comment.
Good spot, the formatter must've ignored it because of the comments
gabrielluong
added
approved
|
This pull request has conflicts when rebasing. Could you fix it @t-p-white? 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant preferences from SettingsFragment being merged first.
No new preferences have been added, this is solely re-arranging the existing preferences to match the UI ordering where applicable.
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1876752