Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1877440 - Use only TestHelper snack bar verification function in UI tests #5371

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

AndiAJ
Copy link
Contributor

@AndiAJ AndiAJ commented Jan 30, 2024

Summary:

  • As mentioned in #5313 the verifySnackBarText function from the CollectionRobot didn't assert anything, only waited for an item containing text
  • Based on this, I've decided to use only the function from TestHelper in all UI tests as we were using this snackbar text verification in multiple robots, mostly having the same implementation, doing the same thing
  • The snackbar text verification done in the normal and compose createCollectionByLongPressingOpenTabsTest UI tests were actually incorrect and because we weren't properly doing an assertion it passed even if we were checking an incorrect string(as mentioned above, the verifySnackBarText function from the CollectionRobot didn't assert anything, only waited for an item containing text)
  • Successfully ran all UI test 3x on Firebase ✅

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1877440

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Jan 30, 2024
@AndiAJ AndiAJ force-pushed the verifySnackBarText branch from 5f2279e to fe65486 Compare January 31, 2024 07:37
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 31, 2024
@AndiAJ AndiAJ force-pushed the verifySnackBarText branch 2 times, most recently from 1590d30 to 45fbffd Compare January 31, 2024 09:08
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 31, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 31, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 31, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 31, 2024
@AndiAJ AndiAJ changed the title Use only TestHelper snack bar verification function in UI tests Bug 1877440 - Use only TestHelper snack bar verification function in UI tests Jan 31, 2024
@AndiAJ AndiAJ force-pushed the verifySnackBarText branch from 45fbffd to ceb3708 Compare January 31, 2024 10:15
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Jan 31, 2024
@AndiAJ AndiAJ marked this pull request as ready for review January 31, 2024 11:16
@AndiAJ AndiAJ requested review from sv-ohorvath and jjSDET January 31, 2024 11:16
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Jan 31, 2024
@AndiAJ AndiAJ assigned AndiAJ and unassigned sv-ohorvath and jjSDET Jan 31, 2024
Copy link
Contributor

@jjSDET jjSDET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good catch here.

@AndiAJ AndiAJ added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 1, 2024
@github-actions github-actions bot added the approved PR that has been approved label Feb 1, 2024
@mergify mergify bot merged commit cb7e919 into mozilla-mobile:main Feb 1, 2024
23 checks passed
@AndiAJ AndiAJ deleted the verifySnackBarText branch February 1, 2024 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants