This repository was archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1877440 - Use only TestHelper snack bar verification function in UI tests #5371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
verifySnackBarText
function from theCollectionRobot
didn't assert anything, only waited for an item containing textTestHelper
in all UI tests as we were using this snackbar text verification in multiple robots, mostly having the same implementation, doing the same thingcreateCollectionByLongPressingOpenTabsTest
UI tests were actually incorrect and because we weren't properly doing an assertion it passed even if we were checking an incorrect string(as mentioned above, theverifySnackBarText
function from theCollectionRobot
didn't assert anything, only waited for an item containing text)Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-apk-{fenix,focus,klar}-debug
task you're interested in.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1877440