Bug 1853058 - Remove Translations Secret Settings and Use Nimbus

[ohall-m]

• This patch removes the secret setting to turn on translations and removes the usage.
• Nimbus feature defaults for translations are all set to false.

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

1. Click on Checks at the top of the PR page.
2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
4. Click on View task in Taskcluster in the new DETAILS section.
5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1853058

[gabrielluong]

If we remove the secret settings and rely on Nimbus, is there still a way to turn on the translation feature manually without having a running experiment (it would be acceptable to say that we will always have a running experiment if it already exists) or having to manually change the nimbus code to enable the feature? Just thinking about what options a regular user or QA would have to turn on the the translations right now without having to fiddle with the code.

I am thinking it might be too early to remove the secret setting since that is the easiest way to manually turn on/off the feature without interfering with Nimbus and making it harder to test or develop the feature.

[ohall-m]

If we remove the secret settings and rely on Nimbus, is there still a way to turn on the translation feature manually without having a running experiment

Thanks for bringing this up! I've communicated with QA and other interested people about this change and what it will mean. I announced it here too. Additional conversation here as well.

Yes, via nimbus-cli (Nimbus CLI Docs) :

nimbus-cli --app fenix --channel developer test-feature translations ~/Desktop/translations-all-enabled.json --no-validate

Where ~/Desktop/translations-all-enabled.json:

{
  "main-flow-toolbar-enabled" : true,
  "main-flow-browser-menu-enabled" : true,
  "page-settings-enabled" : true,
  "global-settings-enabled" : true,
  "global-lang-settings-enabled" : true,
  "global-site-settings-enabled" : true,
  "downloads-enabled" : true
}

Release options are: developer, nightly, beta, and release.

When the experiment is published, it'll also be possible to enable via the Nimbus Secret settings menu.

[ohall-m]

I am thinking it might be too early to remove the secret setting since that is the easiest way to manually turn on/off the feature without interfering with Nimbus and making it harder to test or develop the feature.

Forgot to respond to this! There is a chance we will be running an experiment of some type on the 125 branch, so we need to remove secret settings to stop it from interfering with the experiment results. (If secret settings was a way to override the experiment, then we would have unenrolled experiment users accessing feature areas, which could skew counts.)