This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1879372 - Add enabled/disabled nav button states #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
work in progress
github-actions
bot
added
🕵️♀️ needs review
| @@ -74,16 +76,22 @@ fun BrowserNavBar( | |||
| browserState.normalTabs.size | |||
| } | |||
| }.value | |||
| val canGoBack = browserStore | |||
| .observeAsComposableState { state -> state.selectedTab?.content?.canGoBack }.value ?: false | |||
There was a problem hiding this comment.
Can use observeAsState as above that returns a non null result. Same for the one below.
An idea 💡 : Could create a NavBarUIModel/State to drive the NavBars so there's only one observeAsState that maps to the same UIModel.
There was a problem hiding this comment.
adjusted to observeAsState👍
I like the idea but couldn't find any examples of the usage, usually it's multiple of observeAsComposableState or observeAsState, and hesitant to introduce a new approach in this PR (trying to merge stuff before Friday). Could you point me to an example? Could do it as a follow up.
mavduevskiy
force-pushed
the
bug-1879372
branch
from
440bb56 to
e1ae334
Compare
github-actions
bot
added
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots are order as a navigation sequence: wiki --> link --> back
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1879372