Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1812181 - Firefox for Android crashes submitting form #6041

Closed
wants to merge 1 commit into from

Conversation

AdrianaMaries
Copy link

@AdrianaMaries AdrianaMaries commented Mar 20, 2024

Add a check for fragment attached and current context nullability before using requireContext.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1812181

Copy link
Contributor

🚧 Pull request title is using the wrong format: Firefox for Android crashes submitting form

The pull request title should look like:

  Bug xxxx - Short description of your change

@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 20, 2024
@AdrianaMaries AdrianaMaries changed the title Firefox for Android crashes submitting form Bug 1812181 - Firefox for Android crashes submitting form Mar 20, 2024
@gabrielluong gabrielluong added the followup PR that needs to be followed up label Mar 21, 2024
Add a check for fragment attached and current context nullability before using requireContext.
@gabrielluong
Copy link
Member

Hello @AdrianaMaries, Thank you so much for your contribution. We have moved our firefox-android repo over to mozilla-central. Please feel free to reopen a new PR against the new repo. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see https://github.com/mozilla-mobile/firefox-android/wiki#upcoming-migration-to-mozilla-central.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
followup PR that needs to be followed up 🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants