Review CBOR-serializations in attestation.rs #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschanck
reviewed
Mar 3, 2023
|
|
||
| // TODO(baloo): need to yield credential_data and extensions, but that dependends on flags, | ||
| // should we consider another type system? | ||
| // TODO(MS): Here flags=AT needs to be set, but this data comes from the security device |
There was a problem hiding this comment.
Do we have bugs open for these todos?
There was a problem hiding this comment.
No, because I'm not even sure if there is anything "to do" here at all :) I can open one (or two), if you like.
There was a problem hiding this comment.
I'm not sure I understand the comment, so yes let's open a bug to discuss further.
jschanck
reviewed
Mar 3, 2023
jschanck
approved these changes
Mar 20, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #225 .
We probably want even more tests, though.