Skip to content

Commit

Permalink
Merge pull request #1765 from mozilla/1764-update-entrypoint-ids
Browse files Browse the repository at this point in the history
Fixed #1764 - Revised entry-point IDs to be consistent
  • Loading branch information
maxxcrawford authored Jun 29, 2020
2 parents 174635b + 4da8f00 commit 86b8365
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 28 deletions.
16 changes: 2 additions & 14 deletions views/partials/forms/scan-email-form.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,9 @@
{{/if}}
<div class="input-group-button">
{{#if featuredBreach}}
<input class="breachesSubmitButton add-metrics-flow-values" data-form_type="other"
{{#if experimentFlags.treatmentBranch }}
{{> analytics/fxa id="fx-monitor-homepage-find-out-blue-btn-exp4v2" }}
{{else}}
{{> analytics/fxa id="fx-monitor-homepage-find-out-blue-btn" }}
{{/if}}
type="submit" value="{{ getString "find-out" }}"/>
<input class="breachesSubmitButton add-metrics-flow-values" data-form_type="other" {{> analytics/fxa id="fx-monitor-find-out-blue-btn" }} type="submit" value="{{ getString "find-out" }}"/>
{{else}}
<input class="breachesSubmitButton add-metrics-flow-values" data-form_type="other"
{{#if experimentFlags.treatmentBranch }}
{{> analytics/fxa id="fx-monitor-homepage-check-for-breaches-blue-btn-checked-exp4v2" }}
{{else}}
{{> analytics/fxa id="fx-monitor-homepage-check-for-breaches-blue-btn" }}
{{/if}}
type="submit" value="{{ getString "check-for-breaches" }}"/>
<input class="breachesSubmitButton add-metrics-flow-values" data-form_type="other" {{> analytics/fxa id="fx-monitor-check-for-breaches-blue-btn" }} type="submit" value="{{ getString "check-for-breaches" }}"/>
{{/if}}
{{> forms/loader }}
</div>
Expand Down
16 changes: 2 additions & 14 deletions views/scan.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,7 @@
<h2 class="headline scan-results-headline">{{{ fluentNestedBold "scan-results-known-breaches" breachCount=foundBreaches.length }}}</h2>
<button id="new-scan-page"
class="open-oauth temp-marketing-btn-blue button-top"
{{#if experimentFlags.controlBranch }}
{{> analytics/fxa id="fx-monitor-scan-alert-me-blue-btn-top-exp4v2" }}
{{else if experimentFlags.treatmentBranch }}
{{> analytics/fxa id="fx-monitor-scan-alert-me-blue-btn-top-unchecked-exp4v2" }}
{{else}}
{{> analytics/fxa id="fx-monitor-scan-alert-me-blue-btn-top" }}
{{/if}}
{{> analytics/fxa id="fx-monitor-alert-me-blue-btn-top" }}
data-event-category="Alert me about new breaches"> {{ getString "alert-about-new-breaches" }} </button>
{{/if}}
</div>
Expand Down Expand Up @@ -52,13 +46,7 @@
between this button and the "Alert me.." button on the other version of the scan results page easier
-->
<button class="open-oauth temp-marketing-btn-blue "
{{#if experimentFlags.controlBranch }}
{{> analytics/fxa id="fx-monitor-scan-alert-me-blue-btn-bottom-exp4v2" }}
{{else if experimentFlags.treatmentBranch }}
{{> analytics/fxa id="fx-monitor-scan-alert-me-blue-btn-bottom-unchecked-exp4v2" }}
{{else}}
{{> analytics/fxa id="fx-monitor-scan-alert-me-blue-btn-bottom" }}
{{/if}}
{{> analytics/fxa id="fx-monitor-alert-me-blue-btn-bottom" }}
data-event-category="Alert me about new breaches - Banner">{{ getString "alert-about-new-breaches" }}</button>
{{> sign-up-banners/browser-not-required }}
</div>
Expand Down

0 comments on commit 86b8365

Please sign in to comment.