remove null type

mozilla · Aug 29, 2024 · b9f776b · b9f776b
1 parent 0c7ad96
commit b9f776b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/db/tables/subscribers.ts b/src/db/tables/subscribers.ts
@@ -35,7 +35,7 @@ async function getSubscriberById(id: SubscriberRow["id"]) {
 /* c8 ignore start */
 async function getSubscriberByFxaUid(
   uid: SubscriberRow["fxa_uid"],
-): Promise<SubscriberRow | null> {
+): Promise<SubscriberRow> {
   const [subscriber] = await knex("subscribers").where({
     fxa_uid: uid,
   });
@@ -49,7 +49,7 @@ async function getSubscriberByFxaUid(
 // * @deprecated Use [[getSubscriberByFxAUid]] instead, as email identifiers are unstable (e.g. we've had issues with case-sensitivity).
 async function getSubscriberByEmail(
   email: SubscriberRow["primary_email"],
-): Promise<SubscriberRow | null> {
+): Promise<SubscriberRow> {
   const [subscriber] = await knex("subscribers").where({
     primary_email: email,
     primary_verified: true,

diff --git a/src/knex-tables.d.ts b/src/knex-tables.d.ts
@@ -131,7 +131,7 @@ declare module "knex/types/tables" {
     monthly_email_optout: boolean;
     monthly_monitor_report_at: null | Date;
     monthly_monitor_report: boolean;
-    breach_resolution?: BreachResolution;
+    breach_resolution: BreachResolution;
     onerep_profile_id: null | number;
     sign_in_count: null | number;
     email_addresses: SubscriberEmail[];