Skip to content

Commit

Permalink
Add more Cirrus error logging info (#5483)
Browse files Browse the repository at this point in the history
* Add cirrus logging errors

* remove middleware logging

* revert code change in middleware

* remove logging userId

* remove logging experimentId
  • Loading branch information
codemist authored Jan 14, 2025
1 parent 355dbb0 commit ca3bbf3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/app/functions/server/getExperimentationId.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ export function getExperimentationId(
// If the user is logged in, use the Subscriber ID.
const namespace = process.env.NIMBUS_UUID_NAMESPACE;
if (!namespace) {
logger.error(
"NIMBUS_UUID_NAMESPACE environment variable is missing. Cannot generate experimentationId.",
);
throw new Error(
"NIMBUS_UUID_NAMESPACE not set, cannot create experimentationId",
);
Expand All @@ -47,6 +50,9 @@ export function getExperimentationId(
);
return "guest-no-experimentation-id-set-by-monitor-middleware";
}
logger.info("Using experimentationId from header for guest user", {
experimentationId,
});
return experimentationId as ExperimentationId;
}
}
20 changes: 19 additions & 1 deletion src/app/functions/server/getExperiments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ export async function getExperiments(params: {
serverUrl.searchParams.set("nimbus_preview", "true");
}

logger.info("Sending request to Cirrus", {
serverUrl: serverUrl.toString(),
previewMode: params.previewMode,
});

const response = await fetch(serverUrl, {
headers: {
"Content-Type": "application/json",
Expand All @@ -65,6 +70,14 @@ export async function getExperiments(params: {
}),
});

if (!response.ok) {
logger.error("Cirrus request failed", {
status: response.status,
url: serverUrl.toString(),
});
throw new Error(`Cirrus request failed: ${response.statusText}`);
}

const json = await response.json();

let experimentData;
Expand All @@ -76,7 +89,12 @@ export async function getExperiments(params: {

return (experimentData as ExperimentData) ?? defaultExperimentData;
} catch (ex) {
logger.error("Could not connect to Cirrus", { serverUrl, ex });
logger.error("Could not connect to Cirrus", {
serverUrl,
ex,
flags,
params,
});
captureException(ex);
return defaultExperimentData;
}
Expand Down

0 comments on commit ca3bbf3

Please sign in to comment.