Don't ignore allowlist on "Welcome to Plus" page, remove "HowItWorksPage" flag #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-4897-mgjlpikfea-uk.a.run.app |
flozia
approved these changes
Aug 2, 2024
Otherwise we can't just enable the `SetExpectationsForUsers` flag just for individual accounts.
Vinnl
force-pushed
the
MNTOR-3200-allowlist-plus
branch
from
d4a43f0 to
aa12606
Compare
|
Cleanup completed - database 'blurts-server-pr-4897' destroyed, cloud run service 'blurts-server-pr-4897' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mozilla/blurts-server/pull/4666/files#diff-a54be8bc10c4d286b8f42676102b87a3d78308578c01609682cef692b1d812b9 ignored the allowlist for the Welcome to Plus page when determining whether to link to the "How it works" page, and although that made sense for the public pages, when I now used that same list of enabled flags for the removal time estimation, all of a sudden the allowlist didn't work.
I also removed the
HowItWorksPageflag, since it's now enabled, and had a couple of other allowlist-free feature flag fetches.