-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNTOR-1800: Part 1 - new table for subscriber email preferences #4972
Conversation
Preview URL 🚀 : https://blurts-server-pr-4972-mgjlpikfea-uk.a.run.app |
src/db/migrations/20240822032133_subscriber_email_preferences.js
Outdated
Show resolved
Hide resolved
table.boolean('instant_breach_alert').defaultTo(true); | ||
table.boolean('all_emails_to_primary').defaultTo(true); | ||
table.boolean('monthly_monitor_report').defaultTo(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall reading (but can't find) the advice to instead make this a nullable datetime column *_disabled_at
, would that make sense here? It's not a table that's read or written to particularly often I don't think, so not too much of a load, but would e.g. allow us to notice weird unsubscription patterns, and/or correlate unsubscription spikes with certain events? (Alternatively, simple Glean metrics might be fine too.)
Co-authored-by: Vincent <Vinnl@users.noreply.github.com>
Cleanup completed - database 'blurts-server-pr-4972' destroyed, cloud run service 'blurts-server-pr-4972' destroyed |
References:
Jira: MNTOR-3583
Description
The work to migrate email preferences to a new table need to be done in a few steps:
Checklist (Definition of Done)