MNTOR-3919: getting setter for churn email state (Part 2) #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansaj
changed the title
|
Preview URL 🚀 : https://blurts-server-pr-5480-mgjlpikfea-uk.a.run.app |
rhelmer
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
lgtm although I think @Vinnl asked elsewhere: are we likely to want to do this again? If so, a datestamp might be better than a boolean. If we want to wait and refactor at that time I think it's OK too but worth considering.
decided to go with the ts suggestion |
|
Cleanup completed - database 'blurts-server-pr-5480' destroyed, cloud run service 'blurts-server-pr-5480' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3919
Figma:
Description
These functions will be used by the cronjob to get/set churn email state for a user.
Checklist (Definition of Done)