-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNTOR-3919: cronjob WIP for churn emails #5495
base: main
Are you sure you want to change the base?
Conversation
|
||
const results: FxaChurnSubscriber[] = []; | ||
|
||
return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part is still TBD, I'm looking into perhaps a different way of getting the data in
); | ||
} | ||
|
||
async function sendChurnDiscountEmail(subscriber: FxaChurnSubscriber) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendering of the email part will go here @Vinnl
Preview URL 🚀 : https://blurts-server-pr-5495-mgjlpikfea-uk.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm at a high level - I guess we'd need to remove the unused imports and finalize the way we're getting this data. @mansaj is there any point to storing this in our DB or caching it etc. or are you planning to just read it and move on? Any concern about duplicates (I assume we keep track of who we emailed this to and don't resend)?
ideally we don't store at all. |
References:
Jira: MNTOR-3919
Description
Cronjob for sending out emails
Checklist (Definition of Done)