Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "MNTOR-3814 - use context to fetch experiment data from Cirrus… #5505

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Revert "MNTOR-3814 - use context to fetch experiment data from Cirrus… #5505

merged 1 commit into from
Jan 15, 2025

Conversation

rhelmer
Copy link
Collaborator

@rhelmer rhelmer commented Jan 15, 2025

… (#5440)"

This reverts commit 780dfd4.

References:

Jira: MNTOR-
Figma:

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@rhelmer rhelmer requested a review from codemist January 15, 2025 20:36
@rhelmer rhelmer merged commit 80e7178 into main Jan 15, 2025
11 of 18 checks passed
@rhelmer rhelmer deleted the revert-experiment-context branch January 15, 2025 20:38
Vinnl added a commit that referenced this pull request Jan 16, 2025
@Vinnl
Reapply "MNTOR-3814 - use context to fetch experiment data from Cirrus (
9ba9597 
#5440)" (#5505)

This reverts commit 80e7178.
rhelmer pushed a commit that referenced this pull request Jan 17, 2025
@Vinnl
Undo reverts (#5507)
47ea9a7 
* Reapply "MNTOR-3814 - use context to fetch experiment data from Cirrus (#5440)" (#5505)

This reverts commit 80e7178.

* Revert "handle nimbus user id not set (#5503)"

This reverts commit 4de104f.
rhelmer added a commit that referenced this pull request Jan 17, 2025
@Vinnl @rhelmer
Handle both V1 and V2 of Cirrus' data structure (#5508)
bc950fc 
* Reapply "MNTOR-3814 - use context to fetch experiment data from Cirrus (#5440)" (#5505)

This reverts commit 80e7178.

* Revert "handle nimbus user id not set (#5503)"

This reverts commit 4de104f.

* Handle both V1 and V2 of Cirrus' data structure

---------

Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemist codemist codemist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhelmer @codemist