-
Notifications
You must be signed in to change notification settings - Fork 6
Support rtable on OpenBSD #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 86.76% 86.80% +0.04%
==========================================
Files 5 5
Lines 559 561 +2
Branches 559 561 +2
==========================================
+ Hits 485 487 +2
Misses 48 48
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a merge would need to wait until the OpenBSD rust
package is at 1.82, so we can run CI.
That won't happen until 7.7, which is usually around April. On -current, |
I also started #103 but no dice. |
Thank you for your contribution! |
OpenBSD supports multiple routing tables. The current code doesn't account for that and instead always request the route for routing table 0. If the process is run in another rtable, then this operation will get stuck.
getrtable
isn't part oflibc
crate, but part of OpenBSD's libc. The cast is safe: the syscall never fails, and the actual values are between 0 and 255.Additional details can be found in: