Skip to content

Support rtable on OpenBSD #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025
Merged

Support rtable on OpenBSD #100

merged 5 commits into from
May 5, 2025

Conversation

lgv5
Copy link
Contributor

@lgv5 lgv5 commented Mar 8, 2025

OpenBSD supports multiple routing tables. The current code doesn't account for that and instead always request the route for routing table 0. If the process is run in another rtable, then this operation will get stuck. getrtable isn't part of libc crate, but part of OpenBSD's libc. The cast is safe: the syscall never fails, and the actual values are between 0 and 255.

Additional details can be found in:

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (e7daabb) to head (42bcc02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   86.76%   86.80%   +0.04%     
==========================================
  Files           5        5              
  Lines         559      561       +2     
  Branches      559      561       +2     
==========================================
+ Hits          485      487       +2     
  Misses         48       48              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@larseggert larseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a merge would need to wait until the OpenBSD rust package is at 1.82, so we can run CI.

@lgv5
Copy link
Contributor Author

lgv5 commented Mar 10, 2025

That won't happen until 7.7, which is usually around April. On -current, rustc is at 1.85.0. Sadly, vmactions/openbsd-vm doesn't seem to support running -current.

@larseggert
Copy link
Collaborator

I also started #103 but no dice.

@larseggert larseggert removed the blocked label May 5, 2025
@larseggert larseggert added this pull request to the merge queue May 5, 2025
@larseggert
Copy link
Collaborator

Thank you for your contribution!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 5, 2025
@larseggert larseggert added this pull request to the merge queue May 5, 2025
Merged via the queue into mozilla:main with commit c53ced6 May 5, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants