perf: Optimize packet reception for the common case of adding to the end #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesup
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
martinthomson
previously approved these changes
Jan 26, 2024
|
FYI, it's now about a 9% improvement on my system |
|
Added benchmarks in PR 1609 |
larseggert
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 118 118
Lines 38674 38680 +6
=======================================
+ Hits 33818 33824 +6
Misses 4856 4856 ☔ View full report in Codecov by Sentry. |
larseggert
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization to avoid SmallVec and range in the common case of in-order data reception. Benchmarks on 100000 1337-byte packets shows a 4-7% improvement