Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More green for the neqo fields in the interop runner #1627

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Feb 6, 2024

  • Only allow v1 for most interop runner runs

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (816182f) 87.37% compared to head (1625b29) 87.34%.

Files Patch % Lines
neqo-client/src/main.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
- Coverage   87.37%   87.34%   -0.03%     
==========================================
  Files         124      124              
  Lines       39287    39241      -46     
==========================================
- Hits        34327    34276      -51     
- Misses       4960     4965       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxinden
Copy link
Collaborator

mxinden commented Feb 6, 2024

Am I correctly assuming that this is needed in runs where neqo-client is matched with a server other than neqo-server?

@larseggert
Copy link
Collaborator Author

Not only there. A bunch of other servers will do compatible version upgrades with a neqo client in cases where the test runner doesn't expect this. Like picoquic or haproxy. (The giveaway is Wrong version. Expected 0x1, got ['0x6b3343cf'] at the end of an interop runner log file.

@larseggert larseggert marked this pull request as ready for review February 6, 2024 13:51
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what my review is worth.

@martinthomson martinthomson merged commit b16eaf9 into mozilla:main Feb 6, 2024
10 checks passed
@larseggert larseggert deleted the fix-interop-more-green branch February 7, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants