ci: Use mozilla-actions/sccache-action #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang and
martinthomson
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 120 120
Lines 37029 37029
=======================================
Hits 34403 34403
Misses 2626 2626 ☔ View full report in Codecov by Sentry. |
martinthomson
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
If I'm reading this right, the performance gain here is pretty significant.
The last build on main was:
This build was:
Maybe that reduction isn't as much as you might have liked, but it is still a win. (Edit) ...Mostly. And maybe the cache needs to be primed first.
|
Enabling this now - at least it doesn't seem to hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hm. This doesn't seem to speed things up at all...