ci(sanitize): downgrade to ubuntu v22.04 #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 114 114
Lines 36844 36844
Branches 36844 36844
==========================================
- Hits 35110 35109 -1
- Misses 1728 1729 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
mxinden
force-pushed
the
downgrade-ubuntu
branch
from
ba9f34d to
21934b6
Compare
larseggert
reviewed
Jan 13, 2025
Co-authored-by: Lars Eggert <lars@eggert.org> Signed-off-by: Max Inden <mail@max-inden.de>
@larseggert I will create a pull request against mozilla/mtu. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 085fa62. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
approved these changes
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@larseggert also needs a CI override, given the codecov failure. Can you merge here manually? |
|
I can. Got a pointer to the CodeCov failure? Want to know what is causing it... |
|
@larseggert here is the failure: https://app.codecov.io/gh/mozilla/neqo/commit/c3ecaa666ffe27eb022044d4a452eb09f006f604 I don't understand why it is reporting a reduction in coverage. For the record, here are Neqo's and MTU's config files: |
|
Do you have a link to the CI runs that did or attempted the codecov data upload? Those are usually the issue when there are codecov problems. |
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jan 16, 2025
This reverts commit c3ecaa6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope to fix https://github.com/mozilla/neqo/actions/runs/12745725202/job/35520285659?pr=2352.
See related upstream issue: rust-lang/rust#111073 (comment)