rhino exits the JVM even when run as a subshell of another java shell…

… - bug-835147
mozilla · Mar 10, 2015 · 06710fa · 06710fa
1 parent 7bc14fa
commit 06710fa
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/toolsrc/org/mozilla/javascript/tools/shell/Main.java b/toolsrc/org/mozilla/javascript/tools/shell/Main.java
@@ -147,6 +147,9 @@ public static int exec(String origArgs[])
         errorReporter = new ToolErrorReporter(false, global.getErr());
         shellContextFactory.setErrorReporter(errorReporter);
         String[] args = processOptions(origArgs);
+        if (exitCode > 0) {
+            return exitCode;
+        }
         if (processStdin) {
             fileList.add(null);
         }
@@ -394,7 +397,8 @@ public static String[] processOptions(String args[])
                 // print usage message
                 global.getOut().println(
                     ToolErrorReporter.getMessage("msg.shell.usage", Main.class.getName()));
-                System.exit(1);
+                exitCode = 1;
+                return null;
             }
             usageError = arg;
             break goodUsage;
@@ -404,7 +408,7 @@ public static String[] processOptions(String args[])
             ToolErrorReporter.getMessage("msg.shell.invalid", usageError));
         global.getOut().println(
             ToolErrorReporter.getMessage("msg.shell.usage", Main.class.getName()));
-        System.exit(1);
+        exitCode = 1;
         return null;
     }