Skip to content

fix(ios): make @frozen enums public to resolve Swift compilation warnings #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): make @frozen enums public to resolve Swift compilation warnings #3600

wants to merge 1 commit into from

Conversation

Ash-hs
Copy link

@Ash-hs Ash-hs commented Aug 14, 2025

Summary

This PR fixes Swift compilation warnings related to the attribute on non-public enums.

Problem

Swift compiler emits warnings: for several enum definitions in the iOS Core module.

The attribute can only be applied to enums, not internal ones. Without the modifier, the attribute has no effect and generates compiler warnings.

Solution

  • Added modifier to all enums in the iOS Core module
  • This allows the attribute to work correctly and provide compiler optimizations
  • No functional changes, only access level modifications

Files Changed

    • 2 enums (AbortThrow, OutputConfiguration)
    • 1 enum (TrackType)
  • Types directory - 10 enum files:
    • AutoFocusSystem.swift
    • Flash.swift
    • HardwareLevel.swift
    • OutputOrientation.swift
    • PixelFormat.swift
    • QualityBalance.swift
    • ResizeMode.swift
    • ShutterType.swift
    • Torch.swift
    • VideoStabilizationMode.swift

Testing

  • Swift compilation warnings are resolved
  • No breaking changes to public API (these enums are now properly public)
  • All existing functionality remains unchanged

@Ash-hs
fix(ios): make @Frozen enums public to resolve Swift compilation warn…
7d573eb 
…ings

- Add public modifier to all @Frozen enums in iOS Core module
- @Frozen attribute only works with public enums, not internal ones
- Affects: CameraConfiguration, Track, and all Types enums
- Resolves Swift compiler warning: '@Frozen has no effect on non-public enums'
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready Preview Comment Aug 14, 2025 2:54am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ash-hs