Skip to content

[Select] Move item anchoring prop to Positioner #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 29, 2025
Merged

[Select] Move item anchoring prop to Positioner #1713

merged 14 commits into from
Apr 29, 2025

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Apr 14, 2025 •
edited
Loading

  1. Removes alignItemToTrigger prop from Root, to be configured on Positioner instead
  2. Changes the boolean prop name to alignItemWithTrigger (To -> With)

Closes #1710
Closes #1711

@atomiks atomiks added component: select This is the name of the generic UI component, not the React module! breaking change labels Apr 14, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 14, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 43be92f
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/68109e9607143c00089cfc0f
😎 Deploy Preview https://deploy-preview-1713--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 15, 2025
@atomiks
Merge branch 'master' into fix/select-docs-anchor-item
fd5d772 
Signed-off-by: atomiks <cc.glows@gmail.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2025
@atomiks atomiks marked this pull request as ready for review April 24, 2025 09:46
atomiks and others added 2 commits April 24, 2025 21:18
@atomiks @michaldudak
Update packages/react/src/select/item/useSelectItem.ts
ace8450 
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Signed-off-by: atomiks <cc.glows@gmail.com>
@atomiks @michaldudak
Update packages/react/src/select/root/useSelectRoot.ts
9ed941c 
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Signed-off-by: atomiks <cc.glows@gmail.com>
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2025
@atomiks
Merge branch 'master' into fix/select-docs-anchor-item
b51bc06 
Signed-off-by: atomiks <cc.glows@gmail.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 29, 2025
@atomiks atomiks merged commit ed1c455 into mui:master Apr 29, 2025
22 checks passed
@atomiks atomiks deleted the fix/select-docs-anchor-item branch April 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
breaking change component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
2 participants
@atomiks @michaldudak