[Collapsible] POC using grid-template-*
properties as open/close animation target
#1770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://deploy-preview-1770--base-ui.netlify.app/experiments/collapsible2/transitions
API
The anatomy remains the same, except
Collapsible.Panel
must render an extradiv
around its childrenCSS transitions:
CSS animations:
👍
👎
collapsible2.mov
When transitioning
height
it looks like this:collapsible1.mov
Ariakit has the same issue: https://codesandbox.io/p/sandbox/hungry-goldwasser-mktxk5
It's even more difficult to suppress the initial open animation when using CSS animations
I have followed (at least) the PR section of the contributing guide.