[popups] Refine OpenChangeReason

[atomiks]

Closes #1773

• click -> trigger-press
• hover -> trigger-hover
• focus -> trigger-focus

Not final reasons:

// Preview Card
OpenChangeReason

// Tooltip
OpenChangeReason | 'disabled'

// Popover
// Dialog
// Alert Dialog
OpenChangeReason | 'close-press'

// Select
OpenChangeReason | 'window-resize' | 'item-press' | 'cancel-open';

// Menu
OpenChangeReason | 'item-press' | 'cancel-open';

• close-press occurs when clicking the the Close button part
• item-press occurs when clicking Menu.Item or Select.Item
• cancel-open occurs when they mouseup after mousedown outside of the menu or select

[atomiks]

@michaldudak the API extractor can't handle StringUnion | 'extra-string'?

[michaldudak]

Yeah, there was a bug in how nested unions were handled. Could you update the extractor to https://pkg.pr.new/michaldudak/react-api-extractor@a21d7b8 and see if it helps?

[atomiks]

Works 👍

[netlify]

✅ Deploy Preview for base-ui ready!

Name	Link
🔨 Latest commit	52cf9d5
🔍 Latest deploy log	https://app.netlify.com/sites/base-ui/deploys/68214652255e0900086a39b5
😎 Deploy Preview	https://deploy-preview-1782--base-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[michaldudak]

We should use the publicly exported type here (AlertDialog.Root.OpenChangeReason). If DialogOpenChangeReason is used, devs won't know where to import it from.

[atomiks]

I suppose type only imports don't lead to circular dependency issues?

[atomiks]

The generator can't handle the public type of Select.Root.OpenChangeReason. To be fair, the Actions type is also not clear where it exists from at the moment, so I could just do OpenChangeReason, and maybe the generator (or some manual code) can automatically prepend the component name + Root. Would be useful to still have overrides in this case?

[michaldudak]

Once I update the API extractor to handle types in namespaces, we shouldn't need to use @type annotations manually. Still, an ability to override could be useful sometimes.

[atomiks]

It does seem like they're still needed here

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@1782

commit: 52cf9d5