[material-ui][Select] Fix autoWidth sizing with InputLabel #45862
+49
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
component: select
Netlify deploy previewhttps://deploy-preview-45862--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45276
The implementation of this doesn't quite feel right but the other alternative options I considered had their own problems:
<InputLabel>doesn't resize the the Select as it's position is absolute, changing this could have consequences of which I don't know<InputLabel>to size the Select we would need to get theautoWidthprop from<Select>possibly using<FormControls>useFormControl()hook which seemed like a lot but could be used.